Prepared statement buffer concurrent bug fix#8294
Merged
harshit-gangal merged 2 commits intovitessio:release-8.0from Jun 22, 2021
Merged
Prepared statement buffer concurrent bug fix#8294harshit-gangal merged 2 commits intovitessio:release-8.0from
harshit-gangal merged 2 commits intovitessio:release-8.0from
Conversation
harshit-gangal
approved these changes
Jun 9, 2021
systay
force-pushed
the
send_long_data_buff_fix
branch
from
0ed7c73 to
7d8127f
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
force-pushed
the
send_long_data_buff_fix
branch
from
7d8127f to
99d5e02
Compare
This was referenced Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During high load, if prepared statements are used, the parameter values could accidentally get overwritten with dirty data from other concurrent connections.
This PR fixes this by copying the data before releasing the buffer.
Checklist